From 52c0ddbdc735b9c31474d611c65efeb8db4e73c0 Mon Sep 17 00:00:00 2001 From: Daijiro Fukuda Date: Mon, 4 Apr 2022 16:37:16 +0900 Subject: [PATCH] Add comments to `linger_timeout` behavior about Windows This option is added in https://github.com/fluent/fluentd/pull/3644 However, there was a lack of consideration regarding the default behavior on Windows. Signed-off-by: Daijiro Fukuda --- lib/fluent/plugin_helper/server.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/fluent/plugin_helper/server.rb b/lib/fluent/plugin_helper/server.rb index db4340a796..7e27a09b68 100644 --- a/lib/fluent/plugin_helper/server.rb +++ b/lib/fluent/plugin_helper/server.rb @@ -267,7 +267,9 @@ module ServerTransportParams ### Socket Params ### # SO_LINGER 0 to send RST rather than FIN to avoid lots of connections sitting in TIME_WAIT at src. - # Set positive value if needing to send FIN on closing. + # Set positive value if needing to send FIN on closing on non-Windows. + # (On Windows, Fluentd can send FIN with zero `linger_timeout` since Fluentd doesn't set 0 to SO_LINGER on Windows. + # See `socket_option.rb`.) # NOTE: # Socket-options can be specified from each plugin as needed, so most of them is not defined here for now. # This is because there is no positive reason to do so.