Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fluent-operator helm chart renders incorrectly the container arguments when operator.disableComponentControllers is set. #1159

Open
nickytd opened this issue May 3, 2024 · 0 comments · May be fixed by #1160
Open

bug: Fluent-operator helm chart renders incorrectly the container arguments when operator.disableComponentControllers is set. #1159

nickytd opened this issue May 3, 2024 · 0 comments · May be fixed by #1160

Comments

@nickytd
Copy link
Contributor

nickytd commented May 3, 2024

Describe the issue

fluent-operator goes into CrashLoopback when

operator:
  disableComponentControllers: "fluentd"

is set.

The error is:

2024-05-03T11:17:53Z	ERROR	setup		{"error": "incorrect value for `-disable-component-controllers` and it will not be proceeded (possible values are: fluent-bit, fluentd)"}
main.main
	/workspace/main.go:121
runtime.main
	/usr/local/go/src/runtime/proc.go:267

And is due to the incorrect container template

args:
  - --disable-component-controllers="fluentd"

The correct value shall be

args:
  - "--disable-component-controllers=fluentd"

To Reproduce

Render the current template with

helm template https://github.com/fluent/fluent-operator/releases/download/v2.8.0/fluent-operator-2.8.0.tgz --set operator.disableComponentControllers=fluentd -s templates/fluent-operator-deployment.yaml

It produces:

......
        args:
          - --disable-component-controllers="fluentd"
        volumeMounts:
        - name: env
          mountPath: /fluent-operator
      serviceAccountName: fluent-operator

Expected behavior

Shall produce a valid arguments list and fluent-operator pod shall reach Ready state.

Your Environment

- Fluent Operator version: 2.8.0
- Container Runtime: containerd
- Operating system: linux
- Kernel version: 6.8.0

How did you install fluent operator?

Via the helm chart

Additional context

Fix is provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nickytd