Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test local flow definition installs #4436

Open
Brianzchen opened this issue Apr 18, 2023 · 0 comments
Open

Test local flow definition installs #4436

Brianzchen opened this issue Apr 18, 2023 · 0 comments
Labels
cli Related to CLI tool enhancement An addition to an existing component

Comments

@Brianzchen
Copy link
Member

CLI Version

3.x.x

What problem do you want to solve?

From the recent change 9a968c6 I wasn't able to test the definitions until I merged the changes into master. This can cause unknown regressions

Your take on the correct solution?

In a local project we can normally run node ../flow-typed/cli/dist/cli.js install to validate that the CLI is operating as expected but this will still fetch definitions from github remote servers.

We could add some optional local env var so that when present if we ran the above command it would install the definitions locally.

Anything else?

This might also satisfy another requirement if someone ever wanted to install definitions from another server instead of github.com/flow-typed/flow-typed as they can define their other pathing.

Do you want to submit a pull request to implement this change?

Yes

@Brianzchen Brianzchen added enhancement An addition to an existing component cli Related to CLI tool labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to CLI tool enhancement An addition to an existing component
Projects
None yet
Development

No branches or pull requests

1 participant