Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix if dependency is resolved npm package #4298

Merged
merged 2 commits into from Apr 6, 2022

Conversation

Brianzchen
Copy link
Member

If an npm package has a value that resolves to a different dependency the value does not work with semver and crashes when using the CLI with monorepos.

Tests showcase what is being fixed

cc: @meandmax

@Brianzchen Brianzchen requested a review from gantoine April 6, 2022 06:24
@Brianzchen Brianzchen merged commit c9e7193 into flow-typed:master Apr 6, 2022
@Brianzchen Brianzchen deleted the fix-npm-resolve branch April 6, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants