Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random test failures when run in CI #4263

Open
Brianzchen opened this issue Feb 12, 2022 · 1 comment
Open

Random test failures when run in CI #4263

Brianzchen opened this issue Feb 12, 2022 · 1 comment
Labels
bug cli Related to CLI tool

Comments

@Brianzchen
Copy link
Member

CLI Version

3.6.1

Operating system

Macos

Bug description

When updating a definition, sometimes there are random unrelated failures related to builtin modules that look something like this

Error ----------------------------------------------------------------------------------- <BUILTINS>/react-dom.js:173:18
    
    Cannot resolve name `React$Node`. [cannot-resolve-name]
    
       173|       children?: React$Node,
                             ^^^^^^^^^^

Steps to reproduce

  1. Make a change to a definition and run the ci
  2. Sometimes even if will fail with related issues

Error output/screenshots

No response

Flow configuration

N/A

Anything else?

No response

Do you want to submit a pull request to fix this bug?

Yes, but need help

@Brianzchen Brianzchen added bug cli Related to CLI tool labels Feb 12, 2022
@Brianzchen
Copy link
Member Author

I guess if it's always very stable locally and only failing in CI we can move the run into a script and add some retries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli Related to CLI tool
Projects
None yet
Development

No branches or pull requests

1 participant