Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add a published readme #4182

Merged
merged 5 commits into from Nov 29, 2021
Merged

Conversation

Brianzchen
Copy link
Member

When the cli is published it's currently a little barren right now
https://www.npmjs.com/package/flow-typed

other notes:

  • Should I add anything else?

@gantoine
Copy link
Member

I couldn't figure out why it was empty for the longest time 🤦🏼
Could we copy over the existing README into cli, or symlink it somehow? I think having the full readme on npm would be useful.

@Brianzchen
Copy link
Member Author

I couldn't figure out why it was empty for the longest time 🤦🏼 Could we copy over the existing README into cli, or symlink it somehow? I think having the full readme on npm would be useful.

Makes sense! Updating some script naming too, it would make sense from reading this https://docs.npmjs.com/cli/v8/using-npm/scripts#prepare-and-prepublish

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's perfect 👏🏼

@Brianzchen Brianzchen merged commit 6936a0c into flow-typed:master Nov 29, 2021
@Brianzchen Brianzchen deleted the cli-readme branch November 29, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants