install-test is flaky in CI

[jedwards1211]

Getting this error randomly in some of my PRs (example):

$ jest && yarn lint
FAIL src/commands/__tests__/install-test.js
  ● install (command) › end-to-end tests › overwrites tweaked libdefs when --overwrite is passed

    expect(received).toBe(expected) // Object.is equality

    Expected: "// flow-typed signature: 7a7fa7619340bfebb825752ae5efb893
    // flow-typed version: 0beab4f35a/foo_v1.x.x/flow_>=v0.38.x·
    "
    Received: ""

      631 | 
      632 |         // Verify that the tweaked libdef file wasn't overwritten
    > 633 |         expect(await (await fs.readFile(libdefFilePath)).toString()).toBe(
          |                                                                      ^
      634 |           libdefFileContent,
      635 |         );
      636 |       });

      at toBe (src/commands/__tests__/install-test.js:633:70)
      at src/commands/__tests__/install-test.js:294:11
      at testProject (src/lib/TEST_UTILS.js:31:3)
      at fakeProjectEnv (src/commands/__tests__/install-test.js:271:14)

[jedwards1211]

What's with await (await fs.readFile(libdefFilePath)).toString()? Buffer.toString() is not async. await fs.readFile(libdefFilePath, 'utf8') is equivalent anyway.

[AndrewSouthpaw]

Is this still an issue for you @jedwards1211?

[jedwards1211]

Probably but I don't know yet, my sequelize PR is the first one I've made since reporting this