@reach/router Link with accessiblity

[HenryKenya]

Issues with Link when using it together with a11y. A lot of props are made default, especially those to do with accessKey and accessKeyLabel.

Is this the expected behavior? @AndrewSouthpaw @pascalduez

[pascalduez]

Not 100% sure of what's going on, but looking at the libdef looks quite a good path for problems. Spreading a $Shape of a Class in an inexact object...

[HenryKenya]

@pascalduez my best guess is that because Link spreads HTMLAnchorElement when using accessibility features by introducing a11y props like accessKey become mandatory

[AndrewSouthpaw]

Hmm looking at a Flow Try it seems like spreading a $Shape only makes the props mandatory if the original type had mandatory props.

Looking at the libdef for HTMLAnchorElement, I'm seeing those props as required. That's probably the issue.

I wouldn't expect to see props like accessKey being required though. It makes me wonder if I'm reading it wrong somehow... either that or it's a bug?

[pascalduez]

Looking at the libdef for HTMLAnchorElement, I'm seeing those props as required. That's probably the issue.

It's a class.

[pascalduez]

See #3546

[AndrewSouthpaw]

It's a class.

Woops, makes sense 😅

[HenryKenya]

I guess this issue will be fixed with #3546. I'll leave it open for now and close when the PR is merged.

[HenryKenya]

Hmm looking at a Flow Try it seems like spreading a $Shape only makes the props mandatory if the original type had mandatory props.

Looking at the libdef for HTMLAnchorElement, I'm seeing those props as required. That's probably the issue.

I wouldn't expect to see props like accessKey being required though. It makes me wonder if I'm reading it wrong somehow... either that or it's a bug?

A side note though @AndrewSouthpaw ..While making props like accessKey required is good for accessibility, wouldn't it be better to have it as a maybe type?

[pascalduez]

@HenryKenya I'm pretty sure #3546 won't get any attention anymore.
Would you be willing to take it over? Maybe create another MR with the fix, and more importantly, write extensive tests, to make sure it really fix the issue while still working properly.

[HenryKenya]

I can work on this over the weekend and push another PR @pascalduez