react-redux 7 bug return exact props type component

[ease-space]

problem ConnectedComponent return exact Config props



I fixed this problem

[ease-space]

But OwnProps should be non exact type
Finish fix which also corrects the previous error

[ease-space]

Access danied pull request

[jedwards1211]

@maystrenkoYurii you need to fork this repository and push to your own fork, then you can make a pull request

[jedwards1211]

To do this using the hub CLI:

• install https://github.com/github/hub
• Then:

cd ~/flow-typed
hub fork
hub push --set-upstream maystrenkoYurii react-redux-fix-issue-3788
hub pull-request

[ease-space]

@jedwards1211
sorry but ci build fail and I don't understand why

[jedwards1211]

Yeah, the react-redux types are so complicated I don't know if I can figure it out either. You can run the same tests that CI is running in your local copy by doing this:

cd ~/flow-typed/cli
yarn
node dist/cli.js run-tests react-redux

How come you're using $Exact in

return connect<Props, $Exact<OwnProps>, ...

I assume you get some other errors if you don't use $Exact there?

The new useSelector hook is generally easier to use, especially with Flow. If you use React >=16.8.0 you could do this:

import * as React from 'react'
import { useSelector } from 'react-redux'

export const ResetScrollOnLocationChange = () => {
  const locationUrl = useSelector(getRouterLocationUrlWithReselect)
  const mounted = React.useRef(false)
  React.useEffect(() => {
    if (mounted.current) window.scrollTo(0, 0)
    mounted.current = true
  }, [locationUrl])
  return null
}

And then render <ResetScrollOnLocationChange /> inside any route you want to reset scroll for.

(You can also use connect to build a component like this, instead of wrapping your route components.)

[ease-space]

@jedwards1211 i am run test local without changes node v12 but its fail
add only \n end fail

[AndrewSouthpaw]

Looks like the react-redux_v7 tests are indeed broken in master.

[ease-space]

@jedwards1211
before change

after chenge(before 2 screen) good work in my project

and insurance that the component will return non exact ownProps

I think the resulting component should return Component with non Exact props

but tests failes in master branch even without changes