Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying the maintainers of the json gem #412

Closed
eregon opened this issue May 1, 2020 · 11 comments
Closed

Clarifying the maintainers of the json gem #412

eregon opened this issue May 1, 2020 · 11 comments

Comments

@eregon
Copy link
Contributor

eregon commented May 1, 2020

@flori As mentioned in #402 (comment),
It would be great to have other maintainers for such a critical part of the Ruby standard library.
Can we consider @hsbt @nurse and @headius as maintainers alongside you, which means they should be able to make all decisions needed to maintain this project? (including merging PRs, adding support for new implementations, publish releases, push the gem, etc).
From https://bugs.ruby-lang.org/issues/15605 and many reports before, it's clearly not enough to have a single not-so-active maintainer.
I don't think it's sensible to require the project creator to review/merge every PR.
Therefore I'd like to address the general situation here.

Maybe transferring the project to https://github.com/ruby/json would help to clarify this is a Ruby community-maintained gem. Most other gems in the standard library are under https://github.com/ruby, so I think it would be consistent.

@flori What do you think of that?

There are many open PRs and issues with no response, I think it's high time to have more maintainers for this gem.

Originally posted by @eregon in #402 (comment)

@marcandre
Copy link
Contributor

I can help too.

Where is @flori ?

@simi
Copy link
Contributor

simi commented Jun 24, 2020

Ping me as well if help is needed.

@hsbt
Copy link
Collaborator

hsbt commented Jun 25, 2020

I and @nurse can merge the pull request and maintain the json-2.x releases. I'm not sure what @eregon's request. If you have a issues, you can submit the pull request, triage and more.

@marcandre
Copy link
Contributor

I and @nurse can merge the pull request and maintain the json-2.x releases. I'm not sure what @eregon's request. If you have a issues, you can submit the pull request, triage and more.

Great.

Will this repo move to ruby/json?

Many PRs and issues are outstanding. I will try to help with triage.

@hsbt
Copy link
Collaborator

hsbt commented Jun 25, 2020

Will this repo move to ruby/json?

It's flori's convenience. I and @nurse won't hard-fork to ruby/json from flori/json. It's great to transfer to ruby org from this repository. I'm waiting the decision of @flori

@headius
Copy link
Contributor

headius commented Jun 25, 2020

I already have push rights for the gem but not the repository.

@eregon
Copy link
Contributor Author

eregon commented Jun 25, 2020

My understanding is @hsbt, @nurse and @headius can push a new release in case of need (e.g., security issue), but otherwise they do not consider themselves maintainers.
For example, #402 (comment) took forever to merge, which I believe is for this reason.

So what we need is full maintainers which help maintain the json gem and reduce the backlog.
So far there is a growing number of PRs on this repo, most not even reviewed.

I suggest to add @marcandre to maintainers as he's willing to help here.
Can anyone add @marcandre as a collaborator to this repo? Or only @flori?

I have nothing against @flori but it's a fact he only replies on this gem's tracker once every few months, does not reply to emails often, and ignored this issue so far, even though it's been going on for years.

So, please, @flori, can you let others be full maintainers alongside you, such that the json gem is well maintained?
That is critical to the Ruby ecosystem.
That means those maintainers should have all rights they need: repo push and at least for some gem push, and rights to add more maintainers. I think it would make sense to give @hsbt admin rights, so we don't need to constantly ping @flori if we need any admin-level action.

It's also clear we're all here in favor of moving the repository to the ruby organization, like most other standard libraries/default gems, would that be OK @flori? If so, can you transfer the repository to @hsbt, who will then transfer it to the Ruby organization? (that's the standard procedure on GitHub to transfer a repo from a given user)

If any of you knows a better way to contact @flori, could they ask him to look at this issue?

@eregon
Copy link
Contributor Author

eregon commented Jun 25, 2020

Also, can we give @headius push rights?
It's obviously very important to help maintain the JRuby extension of this gem.

@marcandre
Copy link
Contributor

All open PRs have been reviewed; most can be merged or closed, a few are waiting on executive decisions.

There seems to be work to be done on the JRuby side and the tests suite is not currently passing. Who can work on this?

@hsbt
Copy link
Collaborator

hsbt commented May 27, 2021

I and @nurse can merge PRs and release json gem. and @marcandre handles exists or new issue and PRs. There is no issues json gem now.

I will close this.

@hsbt hsbt closed this as completed May 27, 2021
@eregon
Copy link
Contributor Author

eregon commented May 27, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants