Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version for rails 6.0.0 ? #430

Closed
vinc opened this issue Aug 19, 2019 · 8 comments
Closed

Release new version for rails 6.0.0 ? #430

vinc opened this issue Aug 19, 2019 · 8 comments

Comments

@vinc
Copy link

vinc commented Aug 19, 2019

Hello! Rails 6.0.0 has been released and I've been personally using the latest version of this gem with rc1 and rc2 in production without any issues. Could you release a new version with the changes made to flipper-active_record.gemspec 3 months ago so we can upgrade to rails 6.0.0? 🙏 🎉

@jonnyom
Copy link

jonnyom commented Aug 21, 2019

Big +1, this is our only blocker for upgrading and we'd love to get it done!

@vpereira
Copy link

blocker for us too. Any issue with updating the gem to support 6.0.0 or it's just matter of bump it in the gemspec?

@jonnyom
Copy link

jonnyom commented Sep 3, 2019

Bumping once again! It'd be really great if we could get this done to get ourselves upgraded.

@devinmcgloin
Copy link

devinmcgloin commented Sep 4, 2019

In the same boat over here. This is the only blocker preventing us from upgrading. It's really unfortunate, as it's such a straightforward issue to resolve.

Just in case you've got notifications for the repo off, do you mind releasing the next version @jnunemaker ?

Edit: Apologies! Didn't see the WIP PR.

@vinc
Copy link
Author

vinc commented Sep 4, 2019

You can follow the PR here: #429

And while we are waiting we can use the latest commit of master on this repo in production, that's what I've been doing since opening this issue.

@jnunemaker
Copy link
Collaborator

New version coming soon. Hopefully today.

@jnunemaker
Copy link
Collaborator

0.17 is out on rubygems.

@jnunemaker
Copy link
Collaborator

0.17.1 is out with a fix if you are using flipper-active_record. I yanked the 0.17.0 versions of all gems because #437 basically made that version unusable for rails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants