Skip to content

Unable to download files when Content-Encoding is chunked #85

Closed
@eagletmt

Description

@eagletmt

MiniPortile#download_file_http relies on the Content-Length header, but it isn't sent when Content-Encoding is chunked. In this case, content_length_proc is called with nil.
https://github.com/flavorjones/mini_portile/blob/v2.3.0/lib/mini_portile2/mini_portile.rb#L454-L460
Although mini_portile requests with Accept-Encoding: identity, some servers (e.g., GitHub) respond with Content-Encoding: chunked

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @flavorjones@eagletmt

      Issue actions

        Unable to download files when Content-Encoding is chunked · Issue #85 · flavorjones/mini_portile