Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test both git apply and patch #76

Open
flavorjones opened this issue Mar 19, 2017 · 0 comments
Open

test both git apply and patch #76

flavorjones opened this issue Mar 19, 2017 · 0 comments

Comments

@flavorjones
Copy link
Owner

Currently, the test suite picks git apply if git is installed, else patch.

On both Travis and Appveyor, as well as any likely developer machine, this means that git is tested but patch is not.

I bring this up because gnuwin32's patch.exe on Windows does not handle embedded whitespace in a patch's candidate file name, and so TestCook#test_patch and TestCookWithBrokenGitDir#test_patch both fail on Windows when git is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant