ci: add darwin coverage to the ci matrix, specify timeouts on windows #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-add-darwin-to-ci-matrix
branch
2 times, most recently
from
9007d2b
to
e688644
Compare
flavorjones
changed the title
because on Windows Ruby 3.1+ it takes a minute to timeout by default and that seems too long.
flavorjones
force-pushed
the
flavorjones-add-darwin-to-ci-matrix
branch
from
e688644
to
accaa77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as a change adding Darwin builds to CI.
However, I noticed that Windows 3.1 and head builds were really slow, and looking at the logs I can see that it's because it takes 2 minutes to timeout on failed downloads. So I added a feature whereby timeouts can be specifed, and default to 10 seconds.