address net-ftp warnings #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and let users know what's wrong if they try to use it with a version of Ruby that doesn't provide it by default.
flavorjones
force-pushed
the
105-address-net-ftp-warnings
branch
from
912a907
to
90a7ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5.2 added
net-ftpas a gem dependency to try to anticipate Ruby 3.1 changes.However, for users of Ruby 2.7 and earlier, this resulted in warnings as demonstrated at #105.
This change makes
net-ftpan optional (or "soft") dependency, so that if it's loaded the FTP functionality works; but if it's not loaded then an exception is raised informing the user what's wrong.