Allow boolean and empty attributes for certain node types #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedene
force-pushed
the
fix/allow-empty-attrs
branch
from
0260dd8
to
88941ce
Compare
|
(the force-push: I've squashed my changes up till now in a single commit) |
|
Thanks for submitting this! It may be a day or two before I'm able to review. |
|
@dedene Thank you for your patience! So I'm proceeding carefully here for the moment, since Rails::HTML::Sanitizer is sensitive to empty/boolean attributes. See rails/rails-html-sanitizer#136 for the original description of the general problem back in June 2022. I had been waiting for HTML5 parsing to land in the sanitizer stack before tackling some of these behavioral edge cases. This PR might be the right answer, but I want to try to see if we can get the underlying parser (libgumbo) to do the right thing here first. All of which is to say: I'm going to play with this for a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Loofah in a number of projects where the scrubbing of empty attributes of boolean attributes became an issue. This PR adds support for boolean attributes or empty string values on certain node types. It fixes #242.
I.e.
<option value="">Empty Value</option>is a perfectly safe html, but the empty value was stripped when using the scrubber.It also adds support for boolean attributes (i.e.
downloadon an<a>element, orautoplayon a<video>tag. I could not get Nokogiri to output it as a boolean attributes, but the html5 specification (section 3.2.2) specifies that empty string is also fine.The behaviour from #51 is still the same, so the risk for unwanted regressions is minimal imho.
The tests on Github Action seem to fail for truffleruby. But that seems to be related to ruby/stringio#71 which just got merged and not related to the actual code changes in this PR.
Feel free to make or suggest changes if needed. Thanks a lot for having a look at this!