Adds ARIA attributes

[nick-desteffen]

ARIA Documentation: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA
Specific Attributes: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes

[flavorjones]

Hi, @nick-desteffen! Thanks for submitting this. I just got back from a week on the road for work, so I'm catching up on open-source. I will take a look in the next day or two.

[flavorjones]

@nick-desteffen I'm curious why the following ARIA attributes aren't added in this PR:

                                  "aria-braillelabel",
                                  "aria-brailleroledescription",
                                  "aria-colindextext",
                                  "aria-rowindextext",

which are all listed on the Attributes page you referenced above. I've got a commit ready to push that adds these, but wanted to double-check with you that I'm not missing anything (I'm not very familiar with ARIA).

[nick-desteffen]

@flavorjones I must have missed those, since they aren't listed under one of the 4 main categories.

They are all valid attributes according to the spec, so I think they should be included. Sorry about missing them. Their usage really depends on the screen reader and how compliant you want your application to be.

Official WC3 references:
https://w3c.github.io/aria/#aria-braillelabel
https://w3c.github.io/aria/#aria-brailleroledescription
https://w3c.github.io/aria/#aria-colindextext
https://w3c.github.io/aria/#aria-rowindextext

[flavorjones]

@nick-desteffen would you mind clicking the checkbox on the right that says "Allow edited by maintainers" so I can push an additional commit? I'd prefer that to opening a new PR.

Thanks!

[nick-desteffen]

@flavorjones hmm, I'm not seeing that option. It could be because I didn't open a PR against our fork. I can just add those missing attributes and squash my commits.

[flavorjones]

Huh. OK, well I added a test, too, so I'm going to close this, open a second PR, but keep your commit in history and credit you in the CHANGELOG.

[flavorjones]

Release has been made! Thanks for contibuting this!

https://github.com/flavorjones/loofah/releases/tag/v2.17.0

[nick-desteffen]

🍻 Thank you!