Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sms to ACCEPTABLE_PROTOCOLS #228

Closed
brendon opened this issue Mar 9, 2022 · 3 comments · Fixed by #229
Closed

Adding sms to ACCEPTABLE_PROTOCOLS #228

brendon opened this issue Mar 9, 2022 · 3 comments · Fixed by #229

Comments

@brendon
Copy link
Contributor

brendon commented Mar 9, 2022

Hi there, would you be open to adding sms to ACCEPTABLE_PROTOCOLS?

Seems a strange one to miss given tel is there :)
@flavorjones
Copy link
Owner

Hi, @brendon! Sure, that seems like a fine protocol to add, I'd love if you submitted a pull request.

Check out a1b1da9 for an example commit of a previous addition to protocols.

@brendon brendon mentioned this issue Mar 9, 2022
Merged
@brendon
Copy link
Contributor Author

brendon commented Mar 9, 2022

Sure can (and have)! :) Thanks for the quick response. I just wanted to check if there was a reason for excluding sms before I went ahead with the PR :)

@flavorjones
Copy link
Owner

Released in v2.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow sms: as a valid protocol brendon/loofah
2 participants
@flavorjones @brendon