Update safelist.rb to include overflow-x and y #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests seem to fail on main branch too (at least locally for me). Any ideas there? 🤔 |
|
@sampokuokkanen Thanks for the PR! I'll take a look as soon as I have a bit of time. The tests are likely failing because of Nokogiri's recent upgrade to libxml 2.9.12, please ignore that for now and I'll rebase your branch once that's fixed. |
Just run into the problem of overflow-x and y disappearing. It seems like the end-goal is to not to have to maintain a list like this, but at least in my use case overflow-y is used quite a bit. So it would be pretty great to have it as allowed property too!
|
Rebased! Let's see what CI says now. |
|
Cutting v2.9.10 now. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just run into the problem of overflow-x and y disappearing.
It seems like the end-goal is to not to have to maintain a list like this, but at least in my use case overflow-y is used quite a bit.
So it would be pretty great to have it as allowed property too!