Add border-style keywords #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
requested changes
May 28, 2020
|
@tarcisiozf Thank you for submitting this! Looks great, just had one request which was to follow the convention of listing attributes and keywords in alphabetical order. |
|
@tarcisiozf Just wanted to check if you are open to making the change I requested? |
|
@flavorjones sorry for taking so long to answer, I'll do the requested changes. |
|
@flavorjones done, did I miss anything else? |
|
Looks good, thank you! Merging. |
|
I've shipped loofah v2.6.0 with this change in it, and credited you in the CHANGELOG. Thank you! |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm having some issues when trying to sanitize elements with border-style. I've added the missing keywords following the spec: https://developer.mozilla.org/en-US/docs/Web/CSS/border-style