Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata of final gemspec #181

Merged
merged 2 commits into from Nov 29, 2019

Conversation

JuanitoFatas
Copy link
Contributor

#170 added metadata to the loofah.gemspec. These changes should be made to README. The :: syntax is recommended by seattlerb/hoe@e23f980.

This Pull Request is pending with seattlerb/hoe#98 to have metadata uri support for wiki_uri and mailing_list_uri.

@flavorjones
Copy link
Owner

Hi - thanks for submitting this. Although these changes seem reasonable, I'm not entirely sure I agree with Hoe in tightly coupling the README with the gemspec. Currently wrestling with better ways to do this, for example, see sparklemotion/nokogiri@06c0ca2

@JuanitoFatas
Copy link
Contributor Author

I updated this Pull Request as per sparklemotion/nokogiri@06c0ca2. Feel free to close if you have other preferences. Happy Friday!

@flavorjones
Copy link
Owner

Hi @JuanitoFatas - thanks much for this! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants