Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safelist(s), allowlist(s) where applicable #164

Closed
wants to merge 4 commits into from

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Apr 1, 2019

@flavorjones
Copy link
Owner

Thanks for resubmitting! Planning to spend time on OSS later this week.

@flavorjones
Copy link
Owner

Hi! I've got some time this weekend and would like to get this into the next version of Loofah, v2.3.0.

I'll be pushing some changes on top of your branch to ensure that we can deprecate these names in two stages:

  1. deprecate them, but don't break any users who are directly referencing the old names (e.g., provide aliases for constants and placeholder files)
  2. remove them, which shouldn't happen in a patch version and instead will be a second set of commits for 2.4.0 or maybe 3.0.0.

and this PR would be the first stage. So the commits I'll add will provide backwards-compatibility for now.

@flavorjones
Copy link
Owner

Sorry - now I see you've done this already! I double-checked that the old tests pass with the new code, and that was green, so I'm going to merge this, and it'll be in v2.3.0.

Apologies it took so long to circle back to this.

@flavorjones flavorjones added this to the v2.3.0 milestone Sep 28, 2019
@flavorjones
Copy link
Owner

Merged manually

@flavorjones
Copy link
Owner

v2.3.0 has been released.

Repository owner locked as resolved and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants