Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade to winston 3.x to avoid licensing issue #195

Open
sltam opened this issue Aug 21, 2019 · 5 comments
Open

Please upgrade to winston 3.x to avoid licensing issue #195

sltam opened this issue Aug 21, 2019 · 5 comments

Comments

@sltam
Copy link

sltam commented Aug 21, 2019

Winston 2.x had a dependency on the cycle npm package which has a problematic licensing situation that they refuse to fix. This was subsequently fixed in 3.0.0-rc0.

Would be nice if prompt can upgrade to Winston 3.x to avoid this issue.

@nmccready
Copy link

Its been 2+ years... Can we move or get a response on this?

@nmccready
Copy link

Ahh I see the upgrade path is a nightmare in the unit testing. vows looks like a maintenance nightmare.

@nmccready
Copy link

Bumping wiston with .cli() has breaking changes which causes havoc.

@caub
Copy link
Contributor

caub commented Jan 18, 2022

Yea, I'm maintaining this repo, but I think I'll tell the other owners that we might want to archive this repo. I don't feel like updating its core, instead I think there are alternatives, something simple like https://github.com/heapwolf/prompt-sync for example as suggested by another user, I also made http://github.com/caub/prompt-ajv for an almost drop-in replacement

@mriedem
Copy link

mriedem commented May 5, 2022

Note the comment from #226 (comment) but if you're on prompt 1.3.0 you can do an update and get winston 2.4.6 (I ran npm audit fix in my project to get that) for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants