Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export jpg bug #123

Closed
k4waiiiii opened this issue May 25, 2022 · 17 comments · Fixed by #124
Closed

Export jpg bug #123

k4waiiiii opened this issue May 25, 2022 · 17 comments · Fixed by #124

Comments

@k4waiiiii
Copy link

k4waiiiii commented May 25, 2022

Export sucessfull but file not appear. Inkscape 1.2

@jfacemyer
Copy link

Same here. Just updated to see if this was fixed, it's not.

@hfiguiere
Copy link
Collaborator

you need to explain more in details what you are doing.

@k4waiiiii
Copy link
Author

  • open Inkscape
  • create some object e.g. rectangle
  • export as jpg
  • loading animation for export is complete but file not appear on the file manager.

@hfiguiere
Copy link
Collaborator

you don't say where you export to. I can't really see from here.

@k4waiiiii
Copy link
Author

k4waiiiii commented May 25, 2022

test

png export is work but jpg not.

@jfacemyer
Copy link

Same workflow for exporting works on the official app image, but not the flatpak from flathub.

@k4waiiiii
Copy link
Author

Same workflow for exporting works on the official app image, but not the flatpak from flathub.

Yeah. Before I opened issue in here. Previously, I opened in issue at Inkscape Gitlab and they have no idea about Flatpak.

@hfiguiere
Copy link
Collaborator

You still don't say where you are trying to save the file.

@k4waiiiii
Copy link
Author

k4waiiiii commented May 25, 2022

In home folder?? Sorry, I dont understand. What do you mean "where"?

@hfiguiere
Copy link
Collaborator

it works fine here. So I'm trying to figure out what you are doing. I don't really give much detail.

Unlike the appimage, the flatpak is sandboxed.

@k4waiiiii
Copy link
Author

I'm just normal user. So, I install Inkscape from flathub and then open it, make some design and finish it. After that I export to jpg and file not appear so I report this bug.

@nathanal
Copy link

In the future, please link to your original report and also add all the information over. The Inkscape report refers to https://gitlab.com/inkscape/inbox/-/issues/7048

When trying to save, it appears to succeed but no jpg is created. I also can confirm it happens to me.

This matches an issue we faced in https://gitlab.com/inkscape/extensions/-/issues/416, which was due to a python-Pillow bug (python-pillow/Pillow#5665).

Running the following, it looks like we are on an older version of Pillow that experiences the bug (The pillow fix was merged in ab6efcb925f615d153538e84780f093f7f9f8df2, python-pillow/Pillow#5665, git describe --tags ab6efcb925f615d153538e84780f093f7f9f8df2 gives 8.4.0-122-gab6efcb9,)

flatpak  run --command=sh org.inkscape.Inkscape
python3
>>> import PIL
>>> PIL.__version__
'8.3.2'
>>> 

I assume the solution would be to upgrade the pillow version, is it okay to upgrade to 9.x? (It doesn't look like the fix is in 8.x yet)

@hfiguiere
Copy link
Collaborator

Upgrading to Pillow 9 then.

@hfiguiere
Copy link
Collaborator

tbf JPEG worked fine for me, I couldn't reproduce.

@nathanal
Copy link

I can't explain why jpeg worked for you (I don't see why the bug shouldn't affect everyone. Can you open the jpg file?), but testing the version linked by flathubbot, can confirm the PR fixes the issue 🔥

hfiguiere added a commit that referenced this issue May 26, 2022
- Pillow had a bug for JPEG
- Now use the requirements.txt for the pip-flatpak
@hfiguiere
Copy link
Collaborator

yes I checked the JPEG was valid. Anyway. The new build should be available in a few hours.

@k4waiiiii
Copy link
Author

JPG export is successful now. Thank you for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants