Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST root cerficate expired, effects syncs. #22

Closed
jtagcat opened this issue Sep 30, 2021 · 15 comments
Closed

DST root cerficate expired, effects syncs. #22

jtagcat opened this issue Sep 30, 2021 · 15 comments

Comments

@jtagcat
Copy link

jtagcat commented Sep 30, 2021

syncs: failed, reason: certificate has expired, where the sync server is accessible to the user via other means.

This is very likely due to the DST root cert expiring

Related: laurent22/joplin#3348

It effectively breaks sync.

@GabrielMPhi
Copy link

I have the same problem just this morning.

@Derkades
Copy link

Derkades commented Sep 30, 2021

Same issue using the appimage instead of flatpak. It works fine on android.
(I didn't know there was a flatpak package until I found this issue, I'll definitely move over!)

@jtagcat
Copy link
Author

jtagcat commented Sep 30, 2021

Appimage is upstream, I haven't tested the upstream package yet.

@jtagcat
Copy link
Author

jtagcat commented Sep 30, 2021

Paging @laurent22 @catsout (mobilize for everything is broken spam)

@jtagcat
Copy link
Author

jtagcat commented Sep 30, 2021

Temporary (bad) workaround: Settings → Sync → Ignore TLS failures

@laurent22
Copy link
Collaborator

Is there something that needs to be changed in the app?

@PetrVladimirov
Copy link

PetrVladimirov commented Sep 30, 2021

Same problem is here. Joplin client on Linux (Fedora 33, direct install) doesn't want to sync via valid certificate (Let's Encrypt), Android client syncs.

Checked the certificate itself - URL opens fine via Firefox (without any warnings)
Checked the Nextcloud address via https://whatsmychaincert.com service - it says chain is valid.

@PetrVladimirov
Copy link

PetrVladimirov commented Sep 30, 2021

Is there something that needs to be changed in the app?

From https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/:
What should you do? For most people, nothing at all! We’ve set up our certificate issuance so your web site will do the right thing in most cases, favoring broad compatibility. If you provide an API or have to support IoT devices, you’ll need to make sure of two things: (1) all clients of your API must trust ISRG Root X1 (not just DST Root CA X3), and (2) if clients of your API are using OpenSSL, they must use version 1.1.0 or later. In OpenSSL 1.0.x, a quirk in certificate verification means that even clients that trust ISRG Root X1 will fail when presented with the Android-compatible certificate chain we are recommending by default.

Not sure though whether it should be done in Joplin app or in the package it uses... If the latter, I suppose an issue should be raised to the upstream maintainer.

@chuglo
Copy link

chuglo commented Sep 30, 2021

Same exact issue here. Running Joplin v2.4.9 on Windows 10 client. Let's Encrypt cert. I can confirm the cert IS valid.

@laurent22
Copy link
Collaborator

To fix your server you can follow these steps: electron/electron#31212 (comment)

Hopefully a fix for the desktop app will also be available at some point.

@AUSBird
Copy link

AUSBird commented Sep 30, 2021

Can't ignore TLS failures when using S3
Maybe this should be an option

@laurent22
Copy link
Collaborator

Yes, and I'd accept a PR for it.

@AUSBird
Copy link

AUSBird commented Sep 30, 2021

Unless someone beats me to it, I will give it a crack after work :)

@Felecarpp
Copy link

I have the same issue on Ubuntu 20.04.2 LTS, Joplin 2.4.9, Nextcloud/Let's Encrypt account
I get "reason: certificate has expired" after synthing and I can temporaly fix it with "Ignoring TLS cert errors" also.

@Derkades
Copy link

Derkades commented Oct 2, 2021

It's fixed (in upstream)! https://github.com/laurent22/joplin/releases/tag/v2.5.1

@catsout catsout closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants