Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Wire run with --no-sandbox ? #21

Closed
Mikaela opened this issue May 24, 2019 · 6 comments
Closed

Why does Wire run with --no-sandbox ? #21

Mikaela opened this issue May 24, 2019 · 6 comments

Comments

@Mikaela
Copy link

Mikaela commented May 24, 2019

I was testing if flatpak run com.wire.WireDesktop --startup is the method for starting Wire in the background and looked into htop to see how it affects my memory usage and happened to notice that Wire gets parameter --no-sandbox and I started wondering why? Is Flatpak so well sandboxed that it's unnecessary to have sandboxing in Wire? I think the permissions already look a bit wide.

"finish-args": [
"--device=all",
"--device=dri",
"--filesystem=home",
"--share=ipc",
"--share=network",
"--socket=pulseaudio",
"--socket=wayland",
"--socket=x11",
"--talk-name=com.canonical.AppMenu.Registrar",
"--talk-name=org.freedesktop.Notifications",
"--talk-name=org.freedesktop.secrets"
],

Screenshot from 2019-05-24 08-26-47

@Mikaela
Copy link
Author

Mikaela commented May 24, 2019

This appears to come from Wire upstream judging by wireapp/wire-desktop#2507.

@Mikaela Mikaela closed this as completed May 24, 2019
@TingPing
Copy link
Member

Also the Chrome sandbox can't run inside Flatpak anyway.

@fermulator
Copy link

Why did this get closed? (the question has not been answered) - #2507 is not related

@TingPing
Copy link
Member

TingPing commented Jun 4, 2019

It is impossible to run the current Chromium sandbox inside of Flatpak. So the upstream answer doesn't even matter anyway.

@Mikaela
Copy link
Author

Mikaela commented Jun 9, 2019

It is impossible to run the current Chromium sandbox inside of Flatpak.

Why? Is there an issue about that somewhere? Is Flatpak sandbox more secure than the Chromium one, does it render the Chromium one unrequired?

@TingPing
Copy link
Member

The namespace API is considered insecure so its part of the syscall blacklist.

Chromium would have to be ported to use flatpak-spawn.

No the situation is not more secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants