Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading PHPUnit version notice #1795

Closed
peter279k opened this issue Jun 14, 2019 · 2 comments
Closed

Consider upgrading PHPUnit version notice #1795

peter279k opened this issue Jun 14, 2019 · 2 comments

Comments

@peter279k
Copy link

Feature Request

  • According to this issue, the @expectedException annotation will be deprecated in future PHPUnit versions.
  • According official PHPUnit site, the PHPUnit 6 version supports php-7.0, and it's not supported currently.
    Using PHPUnit 7 or PHPUnit 8 instead.

Suggested solution

  • Upgrading the PHPUnit version to 7 or 8 if possible.
    And it seems that this project still supports php-7.1, I think it's proper to use PHPUnit 7.
  • The @expectedException will be deprecated. Using the expectException method instead.

Once this issue is accepted, I would be happy to do this and create related PR :).

@luceos
Copy link
Member

luceos commented Jun 14, 2019

Yeah this makes a lot of sense. Especially because we already went to php 7.1. Feel free to send in a pr for this.

Thank you for pointing this out 👍

franzliedke added a commit that referenced this issue Jul 29, 2019
@franzliedke
Copy link
Contributor

I've taken care of the deprecated annotation. We're already running PHPUnit 7.

luceos pushed a commit that referenced this issue Feb 4, 2020
wzdiyb pushed a commit to wzdiyb/core that referenced this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants