router: fix slash path trimming #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 17 17
Lines 1129 1129
=======================================
Hits 989 989
Misses 101 101
Partials 39 39 |
1 task
unknwon
approved these changes
Dec 1, 2021
|
https://github.com/flamego/flamego/releases/tag/v1.0.1 has been tagged for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix the wrong path trimming behavior, which makes route
/{**: **}can get the correct parameter value when there is a slash at the end of the path.Link to the issue: #75
Checklist