Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route: add Headers method for matching request headers #133

Merged
merged 4 commits into from Jun 11, 2022

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Jun 11, 2022

Describe the pull request

Use regex to match headers!

Link to the issue: fixes #132

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

Followup

  • Update docs on flamego.dev
  • Update docs on flamego.cn

@unknwon unknwon requested a review from a team June 11, 2022 09:32
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #133 (5b43cf7) into main (7e355eb) will decrease coverage by 0.09%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   89.49%   89.40%   -0.10%     
==========================================
  Files          16       17       +1     
  Lines        1142     1170      +28     
==========================================
+ Hits         1022     1046      +24     
- Misses         80       81       +1     
- Partials       40       43       +3     

router.go Outdated Show resolved Hide resolved
Co-authored-by: E99p1ant <i@github.red>
@unknwon unknwon merged commit 92b5d14 into main Jun 11, 2022
@unknwon unknwon deleted the jc/route-headermatcher branch June 11, 2022 09:58
@unknwon
Copy link
Member Author

unknwon commented Jun 11, 2022

https://github.com/flamego/flamego/releases/tag/v1.5.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

router: add support for HeadersRegexp
2 participants