response_writer: make read and write status code thread safe #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknwon
changed the title
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 87.74% 87.57% -0.17%
==========================================
Files 17 17
Lines 1142 1143 +1
==========================================
- Hits 1002 1001 -1
- Misses 101 102 +1
- Partials 39 40 +1 |
wuhan005
approved these changes
May 13, 2022
|
https://github.com/flamego/flamego/releases/tag/v1.2.1 has been tagged for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Read / write operations of status code was not thread-safe which causes problem when a middleware responds data to the client asynchronously.
Link to the issue: flamego/sse#1
Checklist