Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README file listing flake8 violations defined #1

Closed
peterjc opened this issue Nov 27, 2019 · 3 comments · Fixed by #10
Closed

Add README file listing flake8 violations defined #1

peterjc opened this issue Nov 27, 2019 · 3 comments · Fixed by #10

Comments

@peterjc
Copy link
Collaborator

peterjc commented Nov 27, 2019

I really like the idea of this plugin as a short term solution until black psf/black#26 is fixed.

I would encourage you to add a README file including an example showing what the flake8 error code prefix you are using is (recommended three letter, three number format, e.g. ABC001 to reduce the chance of duplicate codes between plugins). In your case, ISC as a prefix make sense to me.

@peterjc peterjc changed the title Add README file listing flake8 violations define Add README file listing flake8 violations defined Nov 27, 2019
@peterjc
Copy link
Collaborator Author

peterjc commented Nov 27, 2019

I see you are working on this in #2, and have included pip install flake8-implicit-str-concat which I forgot to suggest 👍

@peterjc
Copy link
Collaborator Author

peterjc commented Nov 27, 2019

I filed #3 on the wider issue of not using an alphanumeric flake8 violation code

@keisheiled
Copy link
Collaborator

now that #3 has landed, I'd love to see a PR with this added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants