Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry API requests on server errors #288

Merged
merged 3 commits into from Oct 31, 2022
Merged

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Oct 31, 2022

Closes #287

Since we're compiling it anyway
@actions/github is currently using v6 while @octokit/plugin-retry is
referencing v8 - this results in a mismatch for workflow runs
@paescuj paescuj merged commit 116cb9e into fkirc:master Oct 31, 2022
@paescuj paescuj deleted the retry-api-requests branch October 31, 2022 11:34
maximilianbraun added a commit to crossplane-contrib/xp-testing that referenced this pull request Nov 17, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[fkirc/skip-duplicate-actions](https://togithub.com/fkirc/skip-duplicate-actions)
| action | major | `v2.2.0` -> `v5.3.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>fkirc/skip-duplicate-actions
(fkirc/skip-duplicate-actions)</summary>

###
[`v5.3.1`](https://togithub.com/fkirc/skip-duplicate-actions/compare/v5.3.0...v5.3.1)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v5.3.0...v5.3.1)

###
[`v5.3.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v5.3.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v5.2.0...v5.3.0)

- Retry API requests on server errors by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[fkirc/skip-duplicate-actions#288
-   Update dependencies

###
[`v5.2.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v5.2.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v5.1.0...v5.2.0)

- Add a job summary by [@&#8203;paescuj](https://togithub.com/paescuj)
in
[fkirc/skip-duplicate-actions#277
- Cleanup README by [@&#8203;fkirc](https://togithub.com/fkirc) in
[fkirc/skip-duplicate-actions#278
- Add graphical representation of backtracking-algorithm by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[fkirc/skip-duplicate-actions#279
- Add FAQ section with solution for required matrix jobs by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[fkirc/skip-duplicate-actions#283
- Update dependencies & rebuild by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[fkirc/skip-duplicate-actions#285

###
[`v5.1.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v5.1.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v5.0.0...v5.1.0)

Allow `release` for `do_not_skip` input
([fkirc/skip-duplicate-actions#273)

###
[`v5.0.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v5.0.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v4.0.0...v5.0.0)

Various optimizations:

-   Check all inputs *before* doing any API requests
-   Stricter check for `doNotSkip` input
-   Exclude current workflow run from list of all workflow runs
-   Get rid of redundant and unnecessary lines
-   Add some explaining comments
-   Fix bug with empty `head_repository`
-   Action *might* be a bit faster 🚀

**Breaking changes:**

- Previously, on input and API request errors the action might have
exited successfully but with outputs `should_skip = false` and `reason =
no_workflow_information`. Now, the action will exit with an error
instead.

To make sure that subsequent jobs will not be skipped in such cases it's
recommended to set `continue-on-error: true` in the
`skip-duplicate-actions` job.
Note: This has already been recommended in the past regardless of this
change.
- The structure of the `skipped_by` output (also in `paths_filter`) has
slightly changed for the sake of consistency and alignment with GitHub
API:
    -   `runId` is now `id`
    -   `html_url` is now `htmlUrl`
    -   Full example:
        ```json
        {
         "id": 1709469369,
         "runNumber": 737,
         "event": "pull_request",
         "treeHash": "e3434bb7aeb3047d7df948f09419ac96cf03d73e",
         "commitHash": "4a0432e823468ecff81a978165cb35586544c795",
         "status": "completed",
         "conclusion": "success",
"htmlUrl":
"https://github.com/fkirc/skip-duplicate-actions/actions/runs/1709469369",
         "branch": "master",
         "repo": "fkirc/skip-duplicate-actions",
         "workflowId": 2640563,
         "createdAt": "2022-01-17T18:56:06Z"
        }
        ```

Other changes:

-   Update dependencies

**Full Changelog**:
fkirc/skip-duplicate-actions@v4...v5.0.0

###
[`v4.0.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v4.0.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.4.1...v4.0.0)

Advanced path-filtering and output options
([fkirc/skip-duplicate-actions#181)

###
[`v3.4.1`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.4.1)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.4.0...v3.4.1)

Fix same_content_new bug (runs would be inappropriately skipped)
([fkirc/skip-duplicate-actions#125)

###
[`v3.4.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.4.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.3.0...v3.4.0)

Disable cancellation by default
([#&#8203;93](https://togithub.com/fkirc/skip-duplicate-actions/issues/93))

###
[`v3.3.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.3.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.2.0...v3.3.0)

Improve logging of paths-skipping
([#&#8203;80](https://togithub.com/fkirc/skip-duplicate-actions/issues/80))

###
[`v3.2.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.2.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.1.0...v3.2.0)

Optional duplicate skipping
([#&#8203;74](https://togithub.com/fkirc/skip-duplicate-actions/issues/74))

###
[`v3.1.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.1.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v3.0.0...v3.1.0)

Add an option to skip outdated runs
([fkirc/skip-duplicate-actions#70)

###
[`v3.0.0`](https://togithub.com/fkirc/skip-duplicate-actions/releases/tag/v3.0.0)

[Compare
Source](https://togithub.com/fkirc/skip-duplicate-actions/compare/v2.2.0...v3.0.0)

Make concurrent skipping more powerful and easier to understand
([fkirc/skip-duplicate-actions#66)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/crossplane-contrib/xp-testing).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we add some logic to retry 502 Server errors of the GitHub API?
1 participant