Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.0 #220

Merged
merged 70 commits into from Nov 13, 2022
Merged

v6.0.0 #220

merged 70 commits into from Nov 13, 2022

Conversation

fkhadra
Copy link
Owner

@fkhadra fkhadra commented Nov 2, 2022

Breaking changes

  • removal of theme and animation. Better DX now thanks to typescript
  • removed onShown and onHidden`
  • same signature for useContext.show and contextMenu.show
show({
  event: TriggerEvent;
  id?: MenuId;
  props?: TProps;
  position?: {
    x: number;
    y: number;
  } | null;
})

fmilioni and others added 5 commits February 24, 2021 09:26
Preventing default on keydown causes all inputs on the page to stop working whilst the Menu component is mounted. Some apps have the menu mounted whilst not in use, causing inputs to stop working.

Adds a flag to disable this feature and also makes it work as intended only for keys required for operating the menu that may cause the window to scroll.

Related issue #168
Solv: Add support for hidden predicate to Separator.
@fkhadra
Copy link
Owner Author

fkhadra commented Nov 6, 2022

Hey @ttay24 , thanks for using it. You can expect a release in the coming days, maybe later tonight if I'm able to finish what I have planned.
The code is done, I'm updating the documentation right now.

@fkhadra fkhadra merged commit 58a34bf into main Nov 13, 2022
@JuanmaMenendez
Copy link

hi @fkhadra, a couple of questions if you don't mind:

1- Why did you removed "onShown" and "onHidden" callbacks ?

2- What are the new alternatives to know/react when the menu is shown or hidden?

Thanks

@ossamaweb
Copy link

hi @fkhadra, a couple of questions if you don't mind:

1- Why did you removed "onShown" and "onHidden" callbacks ?

2- What are the new alternatives to know/react when the menu is shown or hidden?

Thanks

check this: https://fkhadra.github.io/react-contexify/track-menu-visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants