Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more lengths for From/Into behind a feature-flag #80

Merged
merged 5 commits into from Jul 8, 2019
Merged

Implement more lengths for From/Into behind a feature-flag #80

merged 5 commits into from Jul 8, 2019

Conversation

novacrazy
Copy link
Collaborator

This including having Travis test and document all features.

I also made the impl_serde module private, because otherwise it would just be an empty module in the docs. Nothing is exported from it anyway.

@novacrazy novacrazy requested a review from fizyk20 July 8, 2019 18:46
fizyk20
fizyk20 approved these changes Jul 8, 2019
View reviewed changes
Copy link
Owner

@fizyk20 fizyk20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one comment (feel free to ignore, though).

.travis.yml Show resolved Hide resolved
@novacrazy novacrazy merged commit 8217a5b into master Jul 8, 2019
@novacrazy novacrazy deleted the more_lens branch July 8, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizyk20 fizyk20 fizyk20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@novacrazy @fizyk20