Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyYAML related tests failure #1123

Closed
vishal-biyani opened this issue Mar 17, 2019 · 2 comments
Closed

PyYAML related tests failure #1123

vishal-biyani opened this issue Mar 17, 2019 · 2 comments

Comments

@vishal-biyani
Copy link
Member

Last few PR builds and builds in master are failing around the same test case which uses PyYAML.

response : a: 1
b:
  c: 3
  d: 4
2019/03/16:16:03:23 response a: 1 b: {c: 3, d: 4} not received

The test scripts which have the failing test case are:

  • test_obj_create_in_diff_ns.sh
  • test_package_command.sh
  • test_buildermgr.sh

The only plausible reason seems a new version of PyYAML (https://pypi.org/project/PyYAML/#history) and that breaks something similar to what is mentioned in docs here:

Dictionaries without nested collections are not dumped correctly
Why does

import yaml
document = """
  a: 1
  b:
    c: 3
    d: 4
"""
print yaml.dump(yaml.load(document))
give

a: 1
b: {c: 3, d: 4}
(see #18, #24)?

@life1347
Copy link
Member

PyYAML ship 5.1 5days ago and changed the default setting of yaml.load from

default_flow_style=None -> default_flow_style=False

Here is the related PR: yaml/pyyaml#256
I get this fixed in PR #1086

@life1347
Copy link
Member

Fixed. Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants