Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ZeroizeOnDrop trait #3232

Closed
jamilbk opened this issue Jan 15, 2024 · 4 comments
Closed

Implement ZeroizeOnDrop trait #3232

jamilbk opened this issue Jan 15, 2024 · 4 comments
Assignees
@thomaseizinger
Labels
area/connlib Firezone's core connectivity library kind/bug Something isn't working kind/security Security-related issues
Milestone
1.0 GA

Comments

@jamilbk
Copy link
Member

jamilbk commented Jan 15, 2024

https://firezonehq.slack.com/archives/C05KAA18L1Z/p1705293435280239
@jamilbk jamilbk added area/connlib Firezone's core connectivity library kind/bug Something isn't working kind/security Security-related issues labels Jan 15, 2024
@jamilbk jamilbk added this to the 1.0-beta milestone Jan 15, 2024
@jamilbk
Copy link
Member Author

jamilbk commented Jan 18, 2024

Refs #3259

@thomaseizinger thomaseizinger self-assigned this Jan 25, 2024
@jamilbk jamilbk modified the milestones: 1.0-beta, 1.0 GA Mar 3, 2024
@thomaseizinger
Copy link
Member

I think this might actually be solved because we are using the secrecy crate and not Zeroize directly.

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

RustCrypto/utils#699

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

Whoops, yeah that might be the case: https://docs.rs/secrecy/latest/secrecy/trait.Zeroize.html

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaseizinger thomaseizinger

Labels
area/connlib Firezone's core connectivity library kind/bug Something isn't working kind/security Security-related issues
Projects
None yet
Milestone
1.0 GA
Development

No branches or pull requests
2 participants
@jamilbk @thomaseizinger