Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not filter the samples and markers by the active tab, only filter the tracks in the active tab view in the tab selection #5000

Open
Tracked by #3215
canova opened this issue May 17, 2024 · 0 comments
Labels
active tab Any features related to the active tab view, where only the current tab info is shown. timeline Issues related to the header timeline view

Comments

@canova
Copy link
Member

canova commented May 17, 2024

This is a sub task of #3215.
In the current active tab view, we filter all the samples and markers by their innerWindowIds. This is not great because if another tab is using a lot of CPU in the background, there is no way to see this because of the filtering. So it's a better idea to not filter samples and markers to give our users more information that can be useful.

We should only filter the timeline tracks instead.

┆Issue is synchronized with this Jira Task

@canova canova changed the title Do not filter the samples and markers by the active tab, only filter the tracks. Do not filter the samples and markers by the active tab, only filter the tracks in the tab selection May 17, 2024
@canova canova changed the title Do not filter the samples and markers by the active tab, only filter the tracks in the tab selection Do not filter the samples and markers by the active tab, only filter the tracks in the active tab view in the tab selection May 17, 2024
@canova canova added the active tab Any features related to the active tab view, where only the current tab info is shown. label May 17, 2024
@canova canova added this to the Single-tab view MVP milestone May 17, 2024
@canova canova added the timeline Issues related to the header timeline view label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active tab Any features related to the active tab view, where only the current tab info is shown. timeline Issues related to the header timeline view
Projects
None yet
Development

No branches or pull requests

1 participant