Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Focusing and excluding by modules #4979

Open
ishitatsuyuki opened this issue May 4, 2024 · 0 comments
Open

Feature: Focusing and excluding by modules #4979

ishitatsuyuki opened this issue May 4, 2024 · 0 comments
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb flame graph Related to the flame graph panel

Comments

@ishitatsuyuki
Copy link

ishitatsuyuki commented May 4, 2024

It's often useful to limit the flame graph to a single module, because you own that module's code and want to optimize it. It's also possible that you have a proprietary module that you can do nothing about it, in which case you would exclude that module.

Right now, the only thing you can do about modules is to collapse their trees. This does not cover the use cases above.

There are a few possibility what Focus on Module M could mean, which needs to be decided:

  1. Include all stacks that contains a frame from Module M. The stacks are not truncated, the bottom frame does not have to be from Module M.
  2. Same as 1., but truncate the stacks at the bottom that are not from Module M. Equivalent to 1. + Focus on function for all the root functions from Module M.
  3. Include only stacks which has Module M at the top frame. This is likely not useful: for example, if Module M calls into libc, this will end up excluding all the frames in libc.

Excluding a particular module should function like the Drop samples from function option, except that function is replaced with samples that contain Module M (in any position of its stack).

┆Issue is synchronized with this Jira Task

@davehunt davehunt added feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb flame graph Related to the flame graph panel labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb flame graph Related to the flame graph panel
Projects
None yet
Development

No branches or pull requests

2 participants