Make it easy to find the line that calls a function #4948
Labels
feature
Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb
source view
Related to the source view feature
Profile: https://share.firefox.dev/3VKdfIO
In this profile, the function
MOZ_Z_adler32
is called by the functionMOZ_Z_inflate
. However,MOZ_Z_inflate
also callsmemcpy
from a different spot in the function and spends more samples there. This means that double-clicking theMOZ_Z_inflate
function only shows the call tomemcpy
in the source view. The call toMOZ_Z_adler32
is somewhere else and you can't easily find it.I'd like there to be a way to easily see the line of code in the source view where
MOZ_Z_adler32
was called fromMOZ_Z_inflate
. (It's line 1191, by the way; the call is via the theUPDATE_CHECK
macro.)Maybe we could have a "go to caller" button in the source view which takes the currently selected call node into account. It would select the parent call node, and open the parent call node's source file in the source view, and scroll to the line which is heaviest among the samples in the previously selected child call node.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: