Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider putting CORS-accessible JS in the source view #4940

Open
mstange opened this issue Mar 19, 2024 · 0 comments
Open

Consider putting CORS-accessible JS in the source view #4940

mstange opened this issue Mar 19, 2024 · 0 comments

Comments

@mstange
Copy link
Contributor

mstange commented Mar 19, 2024

Our source view currently never displays JS source code.

This is for two reasons:

  • The sample-count-per-line information for JS JIT code is currently incomplete (bug 1441689)
  • Most JS code is not CORS-accessible, so we'll have to proxy the requests through the browser.

However, some JS files are CORS-accessible. At the moment we don't even attempt to fetch those files.

We could try to fetch the JS file always, and if it happens to succeed, display it even without accurate sample-per-line information. This would address a subset of use cases.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant