Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for describeInstance #115

Open
haikuoliu opened this issue Aug 27, 2019 · 4 comments
Open

Add support for describeInstance #115

haikuoliu opened this issue Aug 27, 2019 · 4 comments

Comments

@haikuoliu
Copy link

Hi all,

Firecracker-containerd GetVMInfo API doesn't really call the VM API, we want to periodically call some VM API to check if instance is still responsive, we'd like to use describeInstance API for this purpose, but it doesn't seem it's implemented, do you have plan to implement it? Apologize ahead if you already done this.

Thanks,
Haikuo

@kzys
Copy link
Contributor

kzys commented Oct 29, 2019

Currently our Machine interface doesn't expose the underlying client, but we would do that. Please see the discussion on #116.

@kzys
Copy link
Contributor

kzys commented Oct 29, 2019

@kzys
Copy link
Contributor

kzys commented Jun 16, 2020

#116 (comment)

I see that this work was scrapped in favor of providing a getter method for the inner client, I would be willing to implement if the change isn't already in progress.

I'm looking for a way to run a health check against a running VM and know that it is in the running state. Are there any existing solutions?

Hello @olibearo. I think that the definition of "healthy" depends on applications. For example, firecracracker-containerd is launching a small agent process inside a VM. So having a connection to the agent means "healthy" for firecracker-containerd. But other applications would have different definitions.

@mazzy89
Copy link

mazzy89 commented Jul 6, 2020

I'm interested to have a way to check the healthiness of the VM. In my case, I just run firecracker VMs inside a container. Similar to how Ignite does by spawning inside a Docker container a Firecracker VM so in my case I would need to implement a liveness/readiness endpoint that checks the status of the running VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants