Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add phpstan for static analysis #406

Merged
merged 1 commit into from
Feb 17, 2022
Merged

chore: add phpstan for static analysis #406

merged 1 commit into from
Feb 17, 2022

Conversation

bshaffer
Copy link
Collaborator

implements #404

@pabloelcolombiano
Copy link

This is a nice move.

The checks are performed on the lowest level. As described here, we could aim at a level of at least 7.

@bshaffer bshaffer merged commit 13082f8 into main Feb 17, 2022
@bshaffer
Copy link
Collaborator Author

This is a nice move.

The checks are performed on the lowest level. As described here, we could aim at a level of at least 7.

@pabloelcolombiano woops, your comment popped up just as I merged.

I decided to use PHP 8.0 because without it, I was getting the following error:

  Line   Key.php                                                              
 ------ --------------------------------------------------------------------- 
  24     Class OpenSSLAsymmetricKey not found.                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ --------------------------------------------------------------------- 

Do you know how this would be resolved on PHP 7.1? If so, I'm happy to move it.

@bshaffer bshaffer deleted the add-phpstan branch February 17, 2022 14:43
@pabloelcolombiano
Copy link

I mean level 7 of PHPStan, as described in the docs, not the PHP version.

@pabloelcolombiano
Copy link

pabloelcolombiano commented Feb 17, 2022

Here is an example of how I use PHPStan for the fixture factories.

Let me know if you need a PR on that!

@bshaffer
Copy link
Collaborator Author

done in #407!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants