Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, ios): prevent getInitialMessage from being null at the start of the app #9969

Merged
merged 3 commits into from Nov 24, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Nov 21, 2022

Description

Tested the different behavior:

  • Receiving multiples notification and check the good one is in the initialMessage
  • Receiving multiple notifications but opening the app with the icon
  • Opening the app in background state from a notification and check that the initialMessage is null
  • Opening the app in terminated state from a notification and check that the initialMessage is correct

Related Issues

#9906

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@mikehardy
Copy link
Contributor

mikehardy commented Nov 21, 2022

The debate between whether to "consume" the initial message or not was (is?) contentious in react-native-firebase. Because there is possibility of hot-reload etc, we decided to consume them. Otherwise on hot reload the app reacts to the initial native message again which is unwanted. Same with notification and dynamic link

@Lyokone
Copy link
Contributor Author

Lyokone commented Nov 21, 2022

The debate between whether to "consume" the initial message or not was (is?) contentious in react-native-firebase. Because there is possibility of hot-reload etc, we decided to consume them. Otherwise on hot reload the app reacts to the initial native message again which is unwanted. Same with notification and dynamic link

Super interesting, didn't thought about this, I'll revert back to the previous behavior :)

@Lyokone Lyokone merged commit 0b0fea8 into master Nov 24, 2022
@Lyokone Lyokone deleted the fix/9906 branch November 24, 2022 10:27
@firebase firebase locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants