Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): allow null countryCode for phone input #9937

Merged
merged 2 commits into from Nov 23, 2022

Conversation

lesnitsky
Copy link
Member

Related Issues

Closes #9811

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@@ -121,7 +121,7 @@ class _PhoneInputViewState extends State<PhoneInputView> {
widget.subtitleBuilder!(context),
if (state is AwaitingPhoneNumber || state is SMSCodeRequested) ...[
PhoneInput(
initialCountryCode: countryCode!,
initialCountryCode: countryCode,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be most of the time null, because translations will mostly be on language code and not include a countryCode. It would be helpful to check WidgetsBinding.instance.platformDispatcher.locale.countryCode in case Localizations.localeOf(context).countryCode (L93) is null.

@lesnitsky lesnitsky merged commit e87ec8a into master Nov 23, 2022
@lesnitsky lesnitsky deleted the ui/fix-phone-input-crash branch November 23, 2022 21:43
@firebase firebase locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_ui_auth] PhoneInputScreen crashes when locale has no countryCode
4 participants