Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers #9858

Merged
merged 6 commits into from Nov 24, 2022

Conversation

Rexios80
Copy link
Contributor

@Rexios80 Rexios80 commented Nov 4, 2022

Description

I made a custom OAuth provider so that I could add it to the sign in page. The issue is that the existing code expects there to only ever be the providers that exist in this repo. This was causing a crash when fetching the OAuth button label text.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Rexios80 Rexios80 changed the title [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers fix: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers Nov 4, 2022
@Rexios80 Rexios80 changed the title fix: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers feat: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers Nov 4, 2022
@Rexios80
Copy link
Contributor Author

Rexios80 commented Nov 4, 2022

Seems like there are analysis issues in other packages unrelated to this PR. Probably not within the scope of this PR to fix them.

packages/firebase_ui_auth/pubspec.yaml Outdated Show resolved Hide resolved
@lesnitsky
Copy link
Member

@Rexios80 out of curiosity: what provider did you implement? Is this an officially supported provider that is available on firebase console?

@Rexios80
Copy link
Contributor Author

Rexios80 commented Nov 15, 2022

@Lyokone Lyokone merged commit fd0b815 into firebase:master Nov 24, 2022
@Rexios80
Copy link
Contributor Author

Do you want to own that package? Or is it too custom to be in this repo? I was going to publish it myself if you don't see an issue with it.

@lesnitsky
Copy link
Member

@Rexios80 feel free to publish

@firebase firebase locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants