Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Pass the clientId into GoogleSignIn #9823

Merged
merged 1 commit into from Nov 14, 2022

Conversation

TamasBarta
Copy link
Contributor

Description

I started noticing flutter/flutter#114304 when migrating to firebase_ui from flutterfire_ui, and tried to fix it, since I really need to ship an update that depends on not including all the providers. I found that the clientId is not passed into GoogleSignIn, so I tried adding it, which works. I also checked the previous provider implementation from flutterfire_ui which added it too, so I assume this is a mistake that firebase_ui doesn't ATM.

Note that I use Dart-only initialization, it may not surface when the Google plist is included in the iOS app.

By the way, the issue prevents users from logging out regardless of the authentication method they used to log in.

Regarding the checklist: I couldn't manage to run the e2e tests with Melos, I had a ton of Xcode compilation errors, so I gave up on that, the changes are fairly small, and the unit tests passed, so I hope this PR is a good starter to have this issue fixed as it is. Also, I'm not sure how to add tests for these changes, if you want them, please advise.

Thank you.

Related Issues

Flutterfire repo

Main flutter repo

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@lesnitsky lesnitsky merged commit 343e6ed into firebase:master Nov 14, 2022
@TamasBarta TamasBarta deleted the fix-google-sign-in-on-ios branch November 14, 2022 15:50
@firebase firebase locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants