Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin_platform_interface): add verify to QueryPlatform and change internal verifyToken API to verify #9711

Merged
merged 5 commits into from Oct 24, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Oct 11, 2022

Description

Replace verifyToken by verify (verifyToken is going to get deprecated)

  /// Performs the same checks as `verify` but without throwing an
  /// [AssertionError] if `const Object()` is used as the instance token.
  ///
  /// This method will be deprecated in a future release.
  static void verifyToken(PlatformInterface instance, Object token)

I've renamed the verifyExtend method to verify (where possible) since verify matches the underlying naming

It also enforces verify on some missing platforms as noted by the following issues:

Related Issues

#8945
#8095
#8096

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title fix: change verifyToken to verify fix: change verifyToken to verify Oct 12, 2022
@Lyokone Lyokone changed the title fix: change verifyToken to verify fix: add verify to QueryPlatform and change verifyToken to verify Oct 12, 2022
@Lyokone Lyokone marked this pull request as ready for review October 12, 2022 11:40
@Lyokone Lyokone force-pushed the fix/verify branch 2 times, most recently from 717c843 to f0acf30 Compare October 14, 2022 06:13
@Salakar Salakar changed the title fix: add verify to QueryPlatform and change verifyToken to verify fix: add verify to QueryPlatform and change verifyToken to verify Oct 24, 2022
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI failures being fixed

@Salakar Salakar changed the title fix: add verify to QueryPlatform and change verifyToken to verify refactor(plugin_platform_interface): add verify to QueryPlatform and change verifyToken to verify Oct 24, 2022
@Salakar Salakar changed the title refactor(plugin_platform_interface): add verify to QueryPlatform and change verifyToken to verify refactor(plugin_platform_interface): add verify to QueryPlatform and change internal verifyToken API to verify Oct 24, 2022
@Lyokone Lyokone merged commit c99a842 into master Oct 24, 2022
@Lyokone Lyokone deleted the fix/verify branch October 24, 2022 13:26
@firebase firebase locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants