Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crashlytics): parameter information accepts Iterable<Object> for further diagnostic logging information #9678

Merged
merged 2 commits into from Oct 6, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 5, 2022

Description

Updated recordError so it now allows Iterable<Object in the information parameter. This makes it backwards compatible, but also allows users to pass in whatever object they wish (e.g. ['something', 'version']) and it will write it to a String for logging in the Crashlytics dashboard in release mode.

I've tested in release mode using this input:

final err = Exception('AAAAAAAA');
Iterable<Object> properties = ['in release mode'];
FirebaseCrashlytics.instance.recordError(err, StackTrace.current,
    information: properties, fatal: true);

It shows on the dashboard correctly:
Screenshot 2022-10-05 at 10 45 12

Related Issues

fixes #7912

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(crashlytics): allow Object for further diagnostic information fix(crashlytics): parameter information accepts Iterable<Object> for further diagnostic logging information Oct 5, 2022
@russellwheatley
Copy link
Member Author

Hey @kevinthecheung, I have another small doc update if you could take a look, please? Thanks.

@russellwheatley russellwheatley merged commit 2d2b5b0 into master Oct 6, 2022
@russellwheatley russellwheatley deleted the @russell/crash-7912 branch October 6, 2022 08:21
@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants