docs(crashlytics): Use PlatformDispatcher.instance.onError for async errors. Update Crashlytics example app to use "flutterfire-e2e-tests" project.
#9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` and general improvement
|
Hey @kevinthecheung, I've updated the documentation to show users how to record "fatal" & "non-fatal" errors. Could you have a look at the changes and see what you think, please? |
russellwheatley
changed the title
PlatformDispatcher.instance.onError for async errors. Update example apps.PlatformDispatcher.instance.onError for async errors. Update Crashlytics example app to use "flutterfire-e2e-tests".
russellwheatley
changed the title
PlatformDispatcher.instance.onError for async errors. Update Crashlytics example app to use "flutterfire-e2e-tests".PlatformDispatcher.instance.onError for async errors. Update Crashlytics example app to use "flutterfire-e2e-tests" project.
Lyokone
approved these changes
Oct 6, 2022
pr-Mais
approved these changes
Oct 6, 2022
|
Hey @kevinthecheung - could you let me know if the doc changes are acceptable, please? |
kevinthecheung
approved these changes
Oct 25, 2022
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flutter has changed the way it handles errors as of Flutter 3.3 (See this commit).
Updated example app and documentation using latest implementation to catch uncaught async errors:
PlatformDispatcher.instance.onError.I've also updated the docs to be more explicit about what choice of error report is sent to Crashlytics. See: #8815
Also updated the example app to use "flutterfire-e2e-tests" Firebase project. Updated this issue: #9643
Related Issues
Closes #8815
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?